Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log formatted warnings from Rollup #4306

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Log formatted warnings from Rollup #4306

merged 1 commit into from
Oct 5, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Oct 5, 2023 •
edited
Loading

This PR replaces our custom onwarn handler with the Rollup config warnings.flush()

We still break the build on logged warnings, but now includes:

  1. Warnings are formatted by Rollup (exclamation marks, yellow text)
  2. Warnings are included for config plugins like Babel, Terser

Probably a great way to test Rollup v4 in #4304 and split out from #4301

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4306 October 5, 2023 16:00 Inactive
@colinrotherham colinrotherham mentioned this pull request Oct 5, 2023
Merged
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 77.65 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.94 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.99 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.89 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 69.04 KiB
components/accordion/accordion.mjs 21.91 KiB
components/button/button.mjs 4.71 KiB
components/character-count/character-count.mjs 22.03 KiB
components/checkboxes/checkboxes.mjs 5.69 KiB
components/error-summary/error-summary.mjs 6.01 KiB
components/exit-this-page/exit-this-page.mjs 16.61 KiB
components/header/header.mjs 3.84 KiB
components/notification-banner/notification-banner.mjs 4.55 KiB
components/radios/radios.mjs 4.68 KiB
components/skip-link/skip-link.mjs 3.74 KiB
components/tabs/tabs.mjs 9.32 KiB

View stats and visualisations on the review app

Action run for 5650b73

romaricpascal
romaricpascal approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice little improvement! 🥳

@colinrotherham colinrotherham merged commit 2abd9e2 into main Oct 5, 2023
45 checks passed
@colinrotherham colinrotherham deleted the rollup-warnings branch October 5, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaricpascal romaricpascal romaricpascal approved these changes

Assignees
No one assigned
Labels
javascript tooling
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinrotherham @romaricpascal @govuk-design-system-ci